Validate DBP permissions #2673
Merged
Validate DBP permissions #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo/DBP/DBPHomeViewController.swift
github-actions
bot
added
the
bot: not in app board
Bunn
removed
the
bot: not in app board
github-actions
bot
added
the
bot: not in app board
Bunn
removed
the
bot: not in app board
Bunn
commented
Apr 22, 2024
There was a problem hiding this comment.
I moved this to a different file since HomeViewController was getting a bit too crowded.
There was a problem hiding this comment.
Was always a bit random being in there anyway
|
Two current limitations:
Also, would be pretty slick and probably a positive impact on usage if after doing the application move the app opened with the DBP tab still open, but again not a priority for this PR IMO (but worth adding a follow up task for) Otherwise behavior worked as expected |
THISISDINOSAUR
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
@Bunn I’ve added some comments. I want to get your thoughts.
| func checkStatus() -> DataBrokerPrerequisitesStatus | ||
| } | ||
|
|
||
| final class DefaultDataBrokerPrerequisitesStatusVerifier: DataBrokerPrerequisitesStatusVerifier { |
There was a problem hiding this comment.
💡 Let’s add unit tests to this logic
jotaemepereira
approved these changes
Apr 22, 2024
samsymons
added a commit
that referenced
this pull request
Apr 24, 2024
* main: (22 commits) Fix DataBrokerProtectionProcessor.swift lint Fix SwiftLint Add parameter allowed encoding to error descriptions (#2691) Remove debug flags Bump version to 1.85.0 (174) Revert interrupt logic (#2699) Fix downloads not appearing (#2693) Bump version to 1.85.0 (173) DBP interrupt fixes for release (#2696) Bookmark All Tabs (#2683) Fix DBP interrupt function not being cleared on succesful completion (#2690) Bump version to 1.85.0 (172) Validate DBP permissions (#2673) Bump BSK (#2688) Add Untitled tab title (#2650) Stop first scan completed notification being sent if there's an error (#2685) DBP: Rename scanAllBrokers to startManualScan (#2679) macOS: Bundle-Specfic Autofill Secure Vault Keychain Items (#2652) Bump version to 1.85.0 (171) [Release PR] Link Lottie with the NetworkProtectionUI library (#2676) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207136634464353/f
Description:
Display error messages if DBP agent prerequisites aren't met
Steps to test this PR: